Compare commits

...
Author SHA1 Message Date
Lumpiasty 3ff4666495 Add workaround for panic with ts_omit_netstack
ci/woodpecker/pr/pr-build Pipeline was successful
2026-06-16 01:16:45 +02:00
Lumpiasty 43f913cffc Merge pull request 'Don't rebuild image on paths not included in image' (#25) from fix/skip-builds into main
ci/woodpecker/cron/renovate Pipeline was successful
ci/woodpecker/push/release-tag Pipeline was successful
ci/woodpecker/push/pr-build Pipeline was successful
Reviewed-on: #25
2026-06-12 01:17:34 +00:00
Lumpiasty ee5ca68fc3 Don't rebuild image on non-included paths
ci/woodpecker/pr/pr-build Pipeline was successful
2026-06-12 03:06:58 +02:00
3 changed files with 58 additions and 9 deletions
+9 -6
View File
@@ -9,21 +9,24 @@
# Reports pass/fail status back to Gitea, so it shows up as a required check on # Reports pass/fail status back to Gitea, so it shows up as a required check on
# the PR. # the PR.
# Doc-only changes can't affect the image, so they don't trigger the build. # Changes that can't affect the image don't trigger the build: docs and the
# RouterOS-side script (routeros/**: lives on the router, not in the image).
# NOTE: if Gitea is ever configured to REQUIRE this check for merging, a # NOTE: if Gitea is ever configured to REQUIRE this check for merging, a
# doc-only PR will have no check at all — exempt such PRs or merge manually. # PR touching only excluded files will have no check at all — exempt such PRs
# Renovate PRs always touch the Dockerfile or pipeline files, so the # or merge manually. Renovate PRs always touch the Dockerfile or pipeline
# automerge gate is unaffected by these exclusions. # files, so the automerge gate is unaffected by these exclusions.
when: when:
- event: pull_request - event: pull_request
path: path:
exclude: &doc_paths exclude: &non_image_paths
- '**/*.md' - '**/*.md'
- 'docs/**' - 'docs/**'
- 'routeros/**'
- 'renovate.json'
- event: push - event: push
branch: main branch: main
path: path:
exclude: *doc_paths exclude: *non_image_paths
steps: steps:
- name: Build all arches (no push) - name: Build all arches (no push)
+6 -3
View File
@@ -13,9 +13,10 @@
# unchanged, so no tag is created and nothing is released — they ride along # unchanged, so no tag is created and nothing is released — they ride along
# with the next Tailscale bump or manual tag. # with the next Tailscale bump or manual tag.
# Skipped for doc-only pushes: TAILSCALE_VERSION lives in the Dockerfile, so a # Skipped for pushes that can't introduce a new Tailscale version:
# push that doesn't touch non-doc files can never introduce a new version to # TAILSCALE_VERSION lives in the Dockerfile, so a push touching only docs or
# tag (the job would just no-op after spinning up OpenBao + git containers). # the RouterOS-side script can never produce a new version to tag (the job
# would just no-op after spinning up OpenBao + git containers).
when: when:
- event: push - event: push
branch: main branch: main
@@ -23,6 +24,8 @@ when:
exclude: exclude:
- '**/*.md' - '**/*.md'
- 'docs/**' - 'docs/**'
- 'routeros/**'
- 'renovate.json'
steps: steps:
- name: Get git token from OpenBao - name: Get git token from OpenBao
+43
View File
@@ -57,6 +57,49 @@ WORKDIR /src/tailscale
# disables the filter at runtime for debugging — no rebuild needed. # disables the filter at runtime for debugging — no rebuild needed.
COPY patches/stderr_verbosity_filter.go cmd/tailscaled/ COPY patches/stderr_verbosity_filter.go cmd/tailscaled/
# Patch net/tstun/wrap.go: fix panic("unreachable") in invertGSOChecksum for
# ts_omit_netstack builds.
#
# invertGSOChecksum is a gVisor/GSO helper that inverts a transport-layer
# checksum before/after SNAT when gVisor hands us a segment with a partial
# checksum (NeedsCsum=true). It is only meaningful when netstack (gVisor) is
# compiled in (HasNetstack=true).
#
# The function correctly guards its body with:
# if !buildfeatures.HasNetstack { panic("unreachable") }
#
# When built with ts_omit_netstack, HasNetstack is a const false, so that guard
# evaluates to `if true { panic(...) }` — the function always panics.
#
# The problem: invertGSOChecksum is called unconditionally from injectedRead()
# (twice, around pc.snat()), even for the res.data path where res.packet==nil
# and gso is a zero-value netstack_GSO (NeedsCsum=false). The HasNetstack
# guard in the res.packet branch does NOT protect these calls.
#
# As a result, any code path that injects an outbound packet via InjectOutbound()
# — which happens when enabling exit-node use (Tailscale sends TSMP messages
# and synthesizes packets through the TUN injection path) — hits injectedRead
# with res.data!=nil, calls invertGSOChecksum, and crashes with:
# panic: unreachable
# tailscale.com/net/tstun.invertGSOChecksum(...)
# tailscale.com/net/tstun.(*Wrapper).injectedRead(...) wrap.go:1077
#
# Fix: replace the `panic("unreachable")` with a `return` in invertGSOChecksum.
# When HasNetstack=false (ts_omit_netstack), a zero-value netstack_GSO always
# has NeedsCsum=false, so the function is correctly a no-op anyway. This matches
# what the function would do if the rest of its body ran: NeedsCsum=false → return.
#
# The sed expression targets the function precisely: it matches the three-line
# sequence that opens invertGSOChecksum's HasNetstack guard, and replaces only
# the panic line with return. The pattern is stable across minor reformats
# because it anchors on the literal function comment and the specific panic string.
#
# See tailscale/tailscale issue for context (no upstream fix as of v1.98.5):
# panic happens when using exit-node via a ts_omit_netstack build.
RUN sed -i \
-e '/func invertGSOChecksum/,/^}/ s/\t\tpanic("unreachable")/\t\treturn/' \
net/tstun/wrap.go
# Build a minimal combined binary (tailscale CLI + tailscaled daemon in one file). # Build a minimal combined binary (tailscale CLI + tailscaled daemon in one file).
# #
# Tag strategy — ALLOWLIST, not blocklist: # Tag strategy — ALLOWLIST, not blocklist: