NoahandGeorgi Gerganov 1f5accb8d0 Fix garbled output with REPACK at high thread counts (#16956) ...

* Fix garbled output with REPACK at high thread counts

Fixed a race condition in the REPACK matrix multiplication code that caused garbled output when using 26+ threads (model-dependent threshold). The issue occurred because with high thread counts, the code forced chunk count to equal thread count, creating many small chunks. After aligning these chunks to NB_COLS boundaries, adjacent chunks could overlap, causing data corruption and race conditions. The fix enforces minimum chunk sizes based on NB_COLS and caps maximum chunk count to prevent creating too many tiny chunks, ensuring proper alignment without overlaps.

* Update ggml/src/ggml-cpu/repack.cpp

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>

* Update ggml/src/ggml-cpu/repack.cpp

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>

---------

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>

2025-11-03 21:04:59 -08:00

..

amx

ggml : fix unaligned access in AMX code (#16315)

2025-10-06 16:05:27 +03:00

arch

ggml : LoongArch fixes (#16958)

2025-11-03 08:40:02 +02:00

cmake

ggml : build backends as libraries (#10256)

2024-11-14 18:04:35 +01:00

kleidiai

kleidiai: kernel interface refactoring (#16460)

2025-10-09 10:29:17 +03:00

llamafile

llamafile: PowerPC Sgemm Optimization (#15558)

2025-08-26 23:35:25 +08:00

spacemit

ggml : fix SpaceMit IME array out-of-bounds in task assignment (#16629)

2025-10-17 13:01:23 +03:00

arch-fallback.h

ggml-cpu: implement MXFP4 SIMD for s390x (#16193)

2025-09-26 13:27:25 +03:00

binary-ops.cpp

cpu: de-duplicate some of the operators and refactor (ggml/1144)

2025-03-30 08:33:31 +03:00

binary-ops.h

cpu: de-duplicate some of the operators and refactor (ggml/1144)

2025-03-30 08:33:31 +03:00

CMakeLists.txt

ggml: add s390x cpu-feats (#16774)

2025-11-02 08:48:23 +08:00

common.h

ggml : refactor forward_dup for cpu backend (#16062)

2025-09-19 06:31:56 +02:00

ggml-cpu-impl.h

ggml : LoongArch fixes (#16958)

2025-11-03 08:40:02 +02:00

ggml-cpu.c

cpu: introduce chunking for repack matmuls and enable matmul-id chunking on ARM64 (#16833)

2025-10-30 09:06:13 -07:00

ggml-cpu.cpp

ggml: riscv: add riscv spacemit backend (#15288)

2025-09-29 17:50:44 +03:00

hbm.cpp

ggml-cpu : split arch-specific implementations (#13892)

2025-06-09 16:47:13 +02:00

hbm.h

ggml-cpu : split arch-specific implementations (#13892)

2025-06-09 16:47:13 +02:00

ops.cpp

model: add support for qwen3vl series (#16780)

2025-10-30 16:19:14 +01:00

ops.h

ggml: add ops for WAN video model (cuda && cpu) (#15669)

2025-09-04 10:38:49 +02:00

quants.c

llama : add gpt-oss (#15091)

2025-08-05 22:10:36 +03:00

quants.h

llama : add gpt-oss (#15091)

2025-08-05 22:10:36 +03:00

repack.cpp

Fix garbled output with REPACK at high thread counts (#16956)

2025-11-03 21:04:59 -08:00

repack.h

ggml : repack block_iq4_nlx8 (#14904)

2025-08-13 11:09:39 +03:00

simd-mappings.h

ggml : LoongArch fixes (#16958)

2025-11-03 08:40:02 +02:00

traits.cpp

ggml : fix fallback to CPU for ununsupported ops (#15118)

2025-08-06 14:37:35 +02:00

traits.h

ggml : fix fallback to CPU for ununsupported ops (#15118)

2025-08-06 14:37:35 +02:00

unary-ops.cpp

cpu : add FLOOR, CEIL, ROUND and TRUNC unary operators (#16083)

2025-10-15 21:24:51 +02:00

unary-ops.h

cpu : add FLOOR, CEIL, ROUND and TRUNC unary operators (#16083)

2025-10-15 21:24:51 +02:00

vec.cpp

ggml : fix scalar path for computing norm (#16558)

2025-10-13 11:22:27 +03:00

vec.h

Revert "ggml : Leverage the existing GGML_F32_VEC helpers to vectorize ggml_v…" (#16723)

2025-10-22 20:20:55 +02:00