From fb92d8f1873c96ec63f9c59721d58a55bf46d441 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Yongmin=20Yoo=20=EC=9C=A0=EC=9A=A9=EB=AF=BC?= Date: Sat, 25 Jul 2026 21:32:37 +0900 Subject: [PATCH] Update ggml/src/gguf.cpp : Defined virtual keyword for destructor of gguf_writer_base (#25867) Without a virtual destructor, deleting a derived object through a base-class pointer only invokes the base destructor, skipping the derived one. --- ggml/src/gguf.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ggml/src/gguf.cpp b/ggml/src/gguf.cpp index 7920b8100..9f9e4fe5d 100644 --- a/ggml/src/gguf.cpp +++ b/ggml/src/gguf.cpp @@ -1424,7 +1424,7 @@ void gguf_set_tensor_data(struct gguf_context * ctx, const char * name, const vo struct gguf_writer_base { size_t written_bytes {0u}; - ~gguf_writer_base(void) = default; + virtual ~gguf_writer_base(void) = default; // we bet on devirtualization virtual void write(int8_t val) = 0;