llama : build the k-pool selection in the causal mask layout (#30480)
* llama : build the k-pool selection in the causal mask layout - the glm5-next indexer folded the causal mask in through a [n_kv, n_tokens] view: one reshape of the mask ahead of the add, and one of the result ahead of every layer reading the selection, including the shared-indexer layers - build the selection directly in the mask layout, as qwen4exp already does, and drop the now-degenerate reshape in its attention as well - assert the selection width matches the input it is taken from Assisted-by: pi:llama.cpp/Qwen3.8-Flash-Next * cont : remove comment
This commit is contained in:
1 parent
cdce056a3e
commit
e7268bf6a9
2 files changed
+13
-10
No files matched your search
@@ -905,16 +905,16 @@ ggml_tensor * llama_model_qwen4exp::graph::build_attn_qsa(
|
||||
ggml_build_forward_expand(gf, mctx_cur->cpy_v(ctx0, v_cur, v_idxs, il));
|
||||
}
|
||||
|
||||
// the selection mask already carries the causal mask
|
||||
// the selection already carries the causal mask, and it comes in the mask layout
|
||||
ggml_tensor * kq_mask = inp->get_kq_mask();
|
||||
ggml_tensor * mask = ggml_reshape_4d(ctx0, sel, kq_mask->ne[0], kq_mask->ne[1], kq_mask->ne[2], kq_mask->ne[3]);
|
||||
cb(mask, "kq_mask_qsa", il);
|
||||
GGML_ASSERT(ggml_are_same_shape(sel, kq_mask));
|
||||
cb(sel, "kq_mask_qsa", il);
|
||||
|
||||
ggml_tensor * q = q_cur;
|
||||
ggml_tensor * k = mctx_cur->get_k(ctx0, il);
|
||||
ggml_tensor * v = mctx_cur->get_v(ctx0, il);
|
||||
|
||||
ggml_tensor * cur = build_attn_mha(q, k, v, nullptr, mask, nullptr, nullptr, n_sel, kq_scale, il);
|
||||
ggml_tensor * cur = build_attn_mha(q, k, v, nullptr, sel, nullptr, nullptr, n_sel, kq_scale, il);
|
||||
cb(cur, "kqv_out", il);
|
||||
|
||||
// the rotation is its own inverse, so undo it on the value side of the output
|
||||
|
||||
Reference in new issue
Block a user