From c390d0abbccb529e270d389122c674dd74589180 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adrien=20Gallou=C3=ABt?= Date: Fri, 4 Sep 2026 08:13:20 +0200 Subject: [PATCH] common : make build info output stream configurable (#28322) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Let llama_print_build_info write to a caller-provided FILE* instead of hardcoding stderr. The parameter defaults to stderr so existing callers keep their current behavior. The version command in llama-app now passes stdout, so plain version output goes to stdout where users expect it. Signed-off-by: Adrien Gallouët --- app/llama.cpp | 2 +- common/build-info.cpp.in | 6 +++--- common/build-info.h | 4 +++- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/app/llama.cpp b/app/llama.cpp index 3b7e46f20..92f3370be 100644 --- a/app/llama.cpp +++ b/app/llama.cpp @@ -80,7 +80,7 @@ static const command cmds[] = { #undef UPDATE_HIDDEN static int version(int /*argc*/, char ** /*argv*/) { - llama_print_build_info(llama_version()); + llama_print_build_info(llama_version(), stdout); return 0; } diff --git a/common/build-info.cpp.in b/common/build-info.cpp.in index 4ec339708..f194348ca 100644 --- a/common/build-info.cpp.in +++ b/common/build-info.cpp.in @@ -29,7 +29,7 @@ const char * llama_build_info(void) { return s.c_str(); } -void llama_print_build_info(const char * llama_version) { - fprintf(stderr, "version: %s (build %d, commit %s)\n", llama_version, llama_build_number(), llama_commit()); - fprintf(stderr, "built with %s for %s\n", llama_compiler(), llama_build_target()); +void llama_print_build_info(const char * llama_version, FILE * stream) { + fprintf(stream, "version: %s (build %d, commit %s)\n", llama_version, llama_build_number(), llama_commit()); + fprintf(stream, "built with %s for %s\n", llama_compiler(), llama_build_target()); } diff --git a/common/build-info.h b/common/build-info.h index 1e564591a..531097d05 100644 --- a/common/build-info.h +++ b/common/build-info.h @@ -1,5 +1,7 @@ #pragma once +#include + int llama_build_number(void); const char * llama_commit(void); @@ -8,4 +10,4 @@ const char * llama_compiler(void); const char * llama_build_target(void); const char * llama_build_info(void); -void llama_print_build_info(const char *); +void llama_print_build_info(const char *, FILE * = stderr);