From 95db855bce95c0317802b8edd7ab10b05f1f1cc5 Mon Sep 17 00:00:00 2001 From: Georgi Gerganov Date: Mon, 16 Nov 2026 13:27:10 +0200 Subject: [PATCH] ci : use vX.Y.Z tags as docker tags (#32388) * ci : use vX.Y.Z tags as docker tags When the Docker workflow is manually dispatched from a vX.Y.Z tag, use that tag verbatim for the image tags instead of appending the build number and commit hash. Assisted-by: dsh:llama.cpp/ggml-org/DeepSeek-V4.1-Flash-1017-GGUF (Mac Studio, M5 Ultra, 256GB) * ci : require a tag for manual docker runs Manual dispatches of the Docker workflow must now use a tag ref, so the image tags are derived from the selected tag. The check can be skipped with the new skip_ref_check input. Scheduled nightly builds are unchanged. Assisted-by: dsh:llama.cpp/ggml-org/DeepSeek-V4.1-Flash-1017-GGUF (Mac Studio, M5 Ultra, 256GB) --- .github/actions/get-tag-name/action.yml | 4 +++- .github/workflows/docker.yml | 12 ++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/.github/actions/get-tag-name/action.yml b/.github/actions/get-tag-name/action.yml index 46acce582..ad50f8cfc 100644 --- a/.github/actions/get-tag-name/action.yml +++ b/.github/actions/get-tag-name/action.yml @@ -14,7 +14,9 @@ runs: run: | BUILD_NUMBER="$(git rev-list --count HEAD)" SHORT_HASH="$(git rev-parse --short=7 HEAD)" - if [[ "${{ env.BRANCH_NAME }}" == "master" || "${{ env.BRANCH_NAME }}" == "b${BUILD_NUMBER}" ]]; then + if [[ "$GITHUB_REF_TYPE" == "tag" && "${{ env.BRANCH_NAME }}" =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then + echo "name=${{ env.BRANCH_NAME }}" >> $GITHUB_OUTPUT + elif [[ "${{ env.BRANCH_NAME }}" == "master" || "${{ env.BRANCH_NAME }}" == "b${BUILD_NUMBER}" ]]; then echo "name=b${BUILD_NUMBER}" >> $GITHUB_OUTPUT else SAFE_NAME=$(echo "${{ env.BRANCH_NAME }}" | tr '/' '-') diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index ad1a9de9a..778e7b062 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -16,6 +16,10 @@ on: description: "Skip the s390x build target (useful for fast test runs that do not need the IBM Z runner)" type: boolean default: false + skip_ref_check: + description: "Skip the requirement to run from a tag (allows branch refs)" + type: boolean + default: false schedule: # Rebuild daily rather than on every push because it is expensive - cron: '12 4 * * *' @@ -38,6 +42,14 @@ jobs: source_tag: ${{ steps.srctag.outputs.name }} steps: + - name: Check manual run ref + if: ${{ github.event_name == 'workflow_dispatch' && !inputs.skip_ref_check }} + run: | + if [[ "$GITHUB_REF_TYPE" != "tag" ]]; then + echo "::error::Manual runs of this workflow must be started from a tag" + exit 1 + fi + - name: Clone id: checkout uses: actions/checkout@v6