From 7bcbc04fbf4724eb864d05b706638eb5256cc434 Mon Sep 17 00:00:00 2001 From: Xuan-Son Nguyen Date: Wed, 11 Nov 2026 23:42:34 +0100 Subject: [PATCH] ui: move js sandbox setting out of "developer" (#32054) * ui: move js sandbox setting out of "developer" * make js sandbox enabled by default --- tools/ui/src/lib/constants/settings-keys.constants.ts | 1 - tools/ui/src/lib/constants/settings.constants.ts | 10 +--------- tools/ui/src/lib/stores/tools.svelte.ts | 10 ++++------ 3 files changed, 5 insertions(+), 16 deletions(-) diff --git a/tools/ui/src/lib/constants/settings-keys.constants.ts b/tools/ui/src/lib/constants/settings-keys.constants.ts index 456b7017d..910f492a3 100644 --- a/tools/ui/src/lib/constants/settings-keys.constants.ts +++ b/tools/ui/src/lib/constants/settings-keys.constants.ts @@ -33,7 +33,6 @@ export const SETTINGS_KEYS = { FREQUENCY_PENALTY: 'frequency_penalty', FULL_HEIGHT_CODE_BLOCKS: 'fullHeightCodeBlocks', GROUP_MODELS_BY_FAMILY: 'groupModelsByFamily', - JS_SANDBOX_ENABLED: 'jsSandboxEnabled', LIVE_MARKDOWN_PREVIEW: 'liveMarkdownPreview', MAX_IMAGE_RESOLUTION: 'maxImageMPixels', MAX_TOKENS: 'max_tokens', diff --git a/tools/ui/src/lib/constants/settings.constants.ts b/tools/ui/src/lib/constants/settings.constants.ts index 65e192949..9fd0832e1 100644 --- a/tools/ui/src/lib/constants/settings.constants.ts +++ b/tools/ui/src/lib/constants/settings.constants.ts @@ -678,15 +678,7 @@ export const SETTINGS_REGISTRY: SettingsSectionEntry[] = [ }, { defaultValue: false, - help: 'Expose a run_javascript tool to the model. Code runs in a Web Worker inside a sandboxed iframe with an opaque origin, isolated from the WebUI and its API, with a hard timeout.', - key: SETTINGS_KEYS.JS_SANDBOX_ENABLED, - label: 'JavaScript sandbox tool', - type: SettingsFieldType.CHECKBOX - }, - { - defaultValue: false, - dependsOn: SETTINGS_KEYS.JS_SANDBOX_ENABLED, - help: 'Pre-load nerdamer in the sandbox for symbolic computation: simplify, diff, integrate, solve, and more. Requires "JavaScript sandbox tool" to be enabled.', + help: 'Pre-load nerdamer in the run_javascript sandbox for symbolic computation: simplify, diff, integrate, solve, and more.', key: SETTINGS_KEYS.SYMBOLIC_MATH_ENABLED, label: 'Symbolic math (nerdamer)', type: SettingsFieldType.CHECKBOX diff --git a/tools/ui/src/lib/stores/tools.svelte.ts b/tools/ui/src/lib/stores/tools.svelte.ts index 1d4133408..590955970 100644 --- a/tools/ui/src/lib/stores/tools.svelte.ts +++ b/tools/ui/src/lib/stores/tools.svelte.ts @@ -112,12 +112,10 @@ class ToolsStore { } get browserTools(): OpenAIToolDefinition[] { - const tools: OpenAIToolDefinition[] = [buildGetDatetimeToolDefinition()]; - - if (settingsStore.config.jsSandboxEnabled) { - tools.push(buildSandboxToolDefinition(!!settingsStore.config.symbolicMathEnabled)); - } - + const tools: OpenAIToolDefinition[] = [ + buildGetDatetimeToolDefinition(), + buildSandboxToolDefinition(!!settingsStore.config.symbolicMathEnabled) + ]; const readMedia = this.readMediaTool(); if (readMedia) tools.push(readMedia);