Prefer npm ci over install for security (#26601)

This commit is contained in:
Evan Huus
2026-08-05 00:14:22 +02:00
committed by GitHub
parent 4308a4f035
commit 6ea215d171
5 changed files with 7 additions and 7 deletions
+3 -3
View File
@@ -123,15 +123,15 @@ function(npm_build out_var)
endif() endif()
if(need_install) if(need_install)
message(STATUS "UI: running npm install") message(STATUS "UI: running npm ci")
execute_process( execute_process(
COMMAND ${NPM_EXECUTABLE} install COMMAND ${NPM_EXECUTABLE} ci
WORKING_DIRECTORY "${WORK_DIR}" WORKING_DIRECTORY "${WORK_DIR}"
RESULT_VARIABLE rc RESULT_VARIABLE rc
ERROR_VARIABLE err ERROR_VARIABLE err
) )
if(NOT rc EQUAL 0) if(NOT rc EQUAL 0)
message(STATUS "UI: npm install failed (${rc})") message(STATUS "UI: npm ci failed (${rc})")
message(STATUS " stderr: ${err}") message(STATUS " stderr: ${err}")
return() return()
endif() endif()
+1 -1
View File
@@ -89,7 +89,7 @@ Llama UI supports two server operation modes:
```bash ```bash
cd tools/ui cd tools/ui
npm install npm ci
``` ```
### 2. Start llama-server ### 2. Start llama-server
+1 -1
View File
@@ -14,7 +14,7 @@ cd ../../
# Ensure node_modules are installed # Ensure node_modules are installed
if [ ! -d "tools/ui/node_modules" ]; then if [ ! -d "tools/ui/node_modules" ]; then
echo "📦 Installing npm dependencies..." echo "📦 Installing npm dependencies..."
cd tools/ui && npm install && cd ../../ cd tools/ui && npm ci && cd ../../
fi fi
# Check and install git hooks if missing # Check and install git hooks if missing
+1 -1
View File
@@ -14,7 +14,7 @@ cd "$REPO_ROOT/tools/ui"
# Check that node_modules exists # Check that node_modules exists
if [ ! -d "node_modules" ]; then if [ ! -d "node_modules" ]; then
echo "❌ node_modules not found. Run 'npm install' first." echo "❌ node_modules not found. Run 'npm ci' first."
exit 1 exit 1
fi fi
+1 -1
View File
@@ -30,7 +30,7 @@ cd "$REPO_ROOT/tools/ui"
# Check that node_modules exists # Check that node_modules exists
if [ ! -d "node_modules" ]; then if [ ! -d "node_modules" ]; then
echo "❌ node_modules not found. Run 'npm install' first." echo "❌ node_modules not found. Run 'npm ci' first."
exit 1 exit 1
fi fi