Lumpiasty/llama.cpp
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

server : add missing task parameters(adaptive_target, adaptive_decay) in generation_settings (#25830)

Browse Source 
These two parameters were overlooked when task parameters were being JSONized
within `generation_settings` and have been added. A regression test has been
added to prevent the problem from recurring and it passes.

Fixes #25803
This commit is contained in:
Tekin Ertekin
2026-07-25 20:53:08 +02:00
committed by GitHub
parent 720d7fa409
commit 2cfc7670ed
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/server/server-task.cpp
+4
View File
@@ -63,6 +63,8 @@ json task_params::to_json(bool only_metrics) const {
{"mirostat", sampling.mirostat},
{"mirostat_tau", sampling.mirostat_tau},
{"mirostat_eta", sampling.mirostat_eta},
{"adaptive_target", sampling.adaptive_target},
{"adaptive_decay", sampling.adaptive_decay},
{"max_tokens", n_predict},
{"n_predict", n_predict}, // TODO: deduplicate?
{"n_keep", n_keep},
@@ -114,6 +116,8 @@ json task_params::to_json(bool only_metrics) const {
{"mirostat", sampling.mirostat},
{"mirostat_tau", sampling.mirostat_tau},
{"mirostat_eta", sampling.mirostat_eta},
{"adaptive_target", sampling.adaptive_target},
{"adaptive_decay", sampling.adaptive_decay},
{"stop", antiprompt},
{"max_tokens", n_predict},
{"n_predict", n_predict}, // TODO: deduplicate?
tools/server/tests/unit/test_completion.py
+2
View File
@@ -66,6 +66,8 @@ def test_completion_stream(prompt: str, n_predict: int, re_content: str, n_promp
assert server.n_predict is not None
assert data["generation_settings"]["n_predict"] == min(n_predict, server.n_predict)
assert data["generation_settings"]["seed"] == server.seed
assert "adaptive_target" in data["generation_settings"]
assert "adaptive_decay" in data["generation_settings"]
assert match_regex(re_content, content)
else:
assert len(data["tokens"]) > 0